Skip to content

UI: Fixes page size changer doesn't show up on mobile mode#4765

Merged
yadvr merged 2 commits intoapache:4.15from
utchoang:feature/page-size-mobile-view
Mar 29, 2021
Merged

UI: Fixes page size changer doesn't show up on mobile mode#4765
yadvr merged 2 commits intoapache:4.15from
utchoang:feature/page-size-mobile-view

Conversation

@utchoang
Copy link

@utchoang utchoang commented Mar 8, 2021 •
edited
Loading

Description

This PR for fixes page size changer doesn't show up on mobile mode

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

After fixed:
image

How Has This Been Tested?

@utchoang
Copy link
Author

utchoang commented Mar 8, 2021

@blueorangutan ui

@utchoang utchoang mentioned this pull request Mar 8, 2021
Merged
12 tasks
@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 8, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4765 (JID-3854)

@utchoang utchoang marked this pull request as draft March 9, 2021 01:57
@utchoang utchoang marked this pull request as ready for review March 11, 2021 09:03
@utchoang utchoang requested review from shwstppr and yadvr March 15, 2021 06:06
@utchoang utchoang mentioned this pull request Mar 16, 2021
Closed
@yadvr yadvr added this to the 4.15.1.0 milestone Mar 17, 2021
@yadvr
Copy link
Member

yadvr commented Mar 24, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2021

@rhtyd a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 24, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4765 (SL-JID-59)

@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@utchoang Could you remove d998f27 and push ? Thanks

@utchoang utchoang closed this Mar 25, 2021
@utchoang utchoang force-pushed the feature/page-size-mobile-view branch from fc527c0 to 3a82392 Compare March 25, 2021 07:42
@utchoang utchoang reopened this Mar 25, 2021
@davidjumani
Copy link
Contributor

davidjumani commented Mar 25, 2021

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Mar 25, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4765 (SL-JID-70)

@yadvr yadvr merged commit caa55a5 into apache:4.15 Mar 29, 2021
@utchoang utchoang deleted the feature/page-size-mobile-view branch March 30, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@davidjumani davidjumani davidjumani approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

@davidjumani davidjumani

Labels

None yet

Projects

None yet

Milestone

4.15.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@utchoang @blueorangutan @yadvr @davidjumani